OETH L2 Base plugin #1223
OETH L2 Base plugin #1223
Conversation
clement-ux
commented
Oct 30, 2024
clement-ux
commented
- OETH plugin and tests for L2 Base.
|
|
||
| /// @return {ref/tok} Quantity of whole reference units per whole collateral tokens | ||
| /// {superOETHb/wsuperOETHb} | ||
| function underlyingRefPerTok() public view override returns (uint192) { |
There was a problem hiding this comment.
could delete this function entirely if you change the inheritance to ERC4626FiatCollateral
| { | ||
| // {tar/tok} | ||
| // {ETH/wsuperOETHb} | ||
| uint192 targetPerTok = _safeWrap(targetPerTokChainlinkFeed.price()) / 1e18; |
There was a problem hiding this comment.
nit: should probably move the paren outside the 1e18 to minimize overflow risk
|
|
||
| /// @param config.chainlinkFeed - ignored | ||
| /// @param config.oracleTimeout - ignored | ||
| /// @param config.oracleError {1} Should be the oracle error for UoA/tok |
There was a problem hiding this comment.
this should be the combined oracle error I think, since it is applied post-product
There was a problem hiding this comment.
Nice catch, indeed. I remove the comment then 👍
| wsuperOETHb_ETH: bn(86400), | ||
| ETH_USD: bn(1200), | ||
| } | ||
| export const BASE_ORACLE_ERROR = combinedError( |
There was a problem hiding this comment.
what are these 3 errors being added? I was only expecting 2 of them, one per oracle
There was a problem hiding this comment.
Thanks, adjusted 👍
|
|
||
| // {tar/ref} = {tar/tok} / {ref/tok} Get current market peg | ||
| // ETH/superOETHb = ETH/wsuperOETHb / superOETHb/wsuperOETHb | ||
| pegPrice = targetPerTok.div(underlyingRefPerTok()); |
There was a problem hiding this comment.
could do pegPrice = FIX_ONE if these are both operating on the same underlying information
2 participants
